Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lifecycle-operator): remove pre post deploy task evaluation v1beta1 #2782

Merged
merged 76 commits into from
Jan 17, 2024
Merged

chore(lifecycle-operator): remove pre post deploy task evaluation v1beta1 #2782

merged 76 commits into from
Jan 17, 2024

Conversation

geoffrey1330
Copy link
Member

Fixes #2576

Checklist

  • My PR fulfills the Definition of Done of the corresponding issue and not more (or parts if the issue is separated
    into multiple PRs)
  • I used descriptive commit messages to help reviewers understand my thought process
  • I signed off all my commits according to the Developer Certificate of Origin (DCO)
    see Contribution Guide
  • My PR title is formatted according to the semantic PR conventions described in
    the Contribution Guide
  • My code follows the style guidelines of this project (golangci-lint passes, YAMLLint passes)
  • I regenerated the auto-generated docs for Helm and the CRD documentation (if applicable)
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation (if needed)
  • My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test runs)
  • New and existing unit and integration tests pass locally with my changes

@geoffrey1330 geoffrey1330 requested a review from a team as a code owner January 10, 2024 17:02
@geoffrey1330 geoffrey1330 changed the title Chore/2576/remove pre post deploy task evaluation v1beta1 core(lifecycle-operator): remove pre post deploy task evaluation v1beta1 Jan 10, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 10, 2024 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (5d7ebbd) 85.65% compared to head (745f0fd) 85.62%.
Report is 30 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2782      +/-   ##
==========================================
- Coverage   85.65%   85.62%   -0.04%     
==========================================
  Files         160      160              
  Lines       10139    10140       +1     
==========================================
- Hits         8685     8682       -3     
- Misses       1173     1176       +3     
- Partials      281      282       +1
Files Coverage Δ
...tor/apis/lifecycle/v1alpha1/keptnapp_conversion.go 100.00% <ø> (ø)
...tor/apis/lifecycle/v1alpha2/keptnapp_conversion.go 100.00% <ø> (ø)
...tor/apis/lifecycle/v1alpha3/keptnapp_conversion.go 100.00% <ø> (ø)
...-operator/apis/lifecycle/v1beta1/keptnapp_types.go 93.10% <ø> (ø)
...or/apis/lifecycle/v1beta1/keptnappversion_types.go 97.68% <ø> (ø)
...rs/lifecycle/keptnappcreationrequest/controller.go 77.71% <100.00%> (-0.50%) ⬇️
...rator/controllers/lifecycle/keptnapp/controller.go 58.00% <75.00%> (+1.33%) ⬆️

... and 8 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.42% <ø> (ø)
component-tests 56.18% <75.00%> (+0.02%) ⬆️
lifecycle-operator 84.62% <78.57%> (-0.11%) ⬇️
metrics-operator 87.65% <ø> (+0.22%) ⬆️
scheduler 36.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@geoffrey1330 geoffrey1330 changed the title core(lifecycle-operator): remove pre post deploy task evaluation v1beta1 chore(lifecycle-operator): remove pre post deploy task evaluation v1beta1 Jan 10, 2024
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
474eef5 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
96fac2a 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
83cb3c5 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
8ea6c7a 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
125a6ee 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
5546918 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
e7faead 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
aba1543 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
8a50ded 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
fc648d5 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
44da10c 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
a796b8a 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
dece61b 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
6d23422 
Signed-off-by: geoffrey1330 <[email protected]>
@github-actions github-actions bot added the ops label Jan 10, 2024
@odubajDT odubajDT marked this pull request as draft January 11, 2024 06:25
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
4c9d743 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
8b1d7ac 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
41261af 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
1957655 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
2a7cc97 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
7333231 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
e61fce0 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
3a0c8d4 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
ebbe5c2 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
d964e7e 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
60d5098 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
bd6f94c 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
ed73a96 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
1b05780 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
0d4b4a0 
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330 geoffrey1330 marked this pull request as ready for review January 17, 2024 12:35
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

bacherfl
bacherfl approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@bacherfl bacherfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work

@bacherfl bacherfl merged commit 6e992d7 into keptn:main Jan 17, 2024
41 of 42 checks passed
This was referenced Jan 17, 2024
Merged
Merged
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
@geoffrey1330 @bacherfl @Vickysomtee
chore(lifecycle-operator): remove pre post deploy task evaluation v1b…
34faa55 
…eta1 (keptn#2782)

BREAKING CHANGE: Pre/Post evaluations and tasks for an application are now defined in the newly introduced `KeptnAppContext` instead of the `KeptnApp` CRD. `KeptnApps` are now fully managed by the operator and are not intended to be created by the user. The version of a `KeptnApp` will be automatically derived as a function of all workloads that belong to the same application.

Signed-off-by: Geoffrey Israel <[email protected]>
Co-authored-by: Florian Bacher <[email protected]>
Signed-off-by: vickysomtee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RealAnna RealAnna RealAnna left review comments

@odubajDT odubajDT odubajDT approved these changes

@bacherfl bacherfl bacherfl approved these changes

Assignees
No one assigned
Labels
lifecycle-operator ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Pre/Post Deployment Tasks/Evaluations from KeptnApp in v1beta1
4 participants
@geoffrey1330 @bacherfl @RealAnna @odubajDT